Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and rename data-ingest.md to imports.md #297

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

laneymangan
Copy link
Member

during Q1 audit, it was decided to remove the data ingest in lieu of a link to import list in hubspot.

during Q1 audit, it was decided to remove the data ingest in lieu of a link to import list in hubspot. Zapier section was also removed
@AnthonyRollins
Copy link
Member

@thekaveman When you have a moment, I can't figure out why MkDocs failed in this case. It appears to have no conflicts with the base branch but still failed. We can discuss this on our CRM call this week, but curious if there are any fixes here.

@thekaveman
Copy link
Member

Hey all, the issue is due to a file being deleted (actually, renamed) and that file is still referenced:

  • In this commit, a link was added to the menu for What is a CRM.md: 07798eb
  • In the next commit that file was renamed to what-is-a-crm.md, but the menu link was not updated: 648d6f1

So now the site is actually failing to publish at all: https://github.com/cal-itp/customer-success/actions/runs/5684201372/job/15406385172#step:4:101

mkdocs_awesome_pages_plugin.navigation.NavEntryNotFound:
    Nav entry "What is a CRM.md" not found. [/github/workspace/docs/getting-started/.pages]

Fixing this

  • Short term, update the docs/getting-started/.pages file to fix the link to the now renamed file
  • Long term, we should add some branch protection rules to prevent this kind of thing. Normally you don't want to commit directly to the main branch just in case something breaks, you want to go through a PR that runs all the checks (like this preview) before merging to main.

@AnthonyRollins
Copy link
Member

@thekaveman Would it be okay to merge this one in and then #303 to fix the naming issue mistake? We should have added a commit change to this PR but created a new pull request (#303) to fix the name mistake. Let me know the best way to handle this current situation and this going forward.

@thekaveman
Copy link
Member

@AnthonyRollins @laneymangan I would just add one more commit here, no need to split that across multiple PRs, since this one isn't even building the preview currently.

@github-actions
Copy link

@AnthonyRollins AnthonyRollins merged commit 35d8f7b into main Aug 15, 2023
1 check passed
@AnthonyRollins AnthonyRollins deleted the removed-zapier-removed-ingest-added-imports branch August 15, 2023 22:39
@AnthonyRollins AnthonyRollins mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants